Skip to content

docs(powerbi): note Cube only supports live connection mode#11038

Merged
keydunov merged 1 commit into
masterfrom
docs-powerbi-live-connection-only
Jun 8, 2026
Merged

docs(powerbi): note Cube only supports live connection mode#11038
keydunov merged 1 commit into
masterfrom
docs-powerbi-live-connection-only

Conversation

@keydunov

@keydunov keydunov commented Jun 8, 2026

Copy link
Copy Markdown
Member

DirectQuery is not supported. Add a warning callout and link to Microsoft's Power BI docs for live connection and DirectQuery.

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 38s —— View job


Code Review

Verdict: LGTM — clear, accurate clarification. One small wording suggestion below.

Review details
  • Read PR diff
  • Read file in context
  • Check Mintlify conventions
  • Post review

Observations

Wording redundancy (low): After the new <Warning>, the next paragraph still says:

It's recommended to use a live connection whenever possible. Import mode is not recommended, as it removes the benefits of using a semantic layer.

Since the Warning already states live connection is the only supported mode, "whenever possible" reads oddly — the only alternative the reader sees is Import mode, which the same sentence then discourages. Consider either dropping the recommendation sentence and keeping just the Import mode caveat, e.g.:

_Import mode_ is not recommended, as it removes the benefits of using a semantic layer.

Not blocking — just a tightness pass.

Link target (nit): [link-powerbi-live] points to desktop-directquery-about#live-connections, i.e. the DirectQuery page anchored to a live-connection section. The link is valid but visually inconsistent with [link-powerbi-directquery] pointing to the same base URL. If Microsoft has a dedicated live-connection overview page, that may read cleaner — but the current anchor is fine.

Trailing newline: The file still ends without a trailing newline (pre-existing, not introduced here). Minor — most linters prefer one.

Mintlify conventions: <Warning> block formatting is correct (blank lines inside the tags), root-relative links unchanged, no nav update needed.

• [`docs-powerbi-live-connection-only`](https://github.com/cube-js/cube/tree/docs-powerbi-live-connection-only)

@mintlify

mintlify Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
cubed3 🟢 Ready View Preview Jun 8, 2026, 7:48 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 48s —— View job


Code Review

Verdict: LGTM — 0 blocking, 1 nit.

Review details
  • Read PR diff
  • Read current file state
  • Compare against prior commit (559bef7)
  • Check Mintlify conventions
  • Post review

Observations

Change is clean. The new commit replaces the entire __It's recommended to use a _live connection_ whenever possible.__ Use _DirectQuery_... paragraph with a <Warning> callout stating that Cube only supports live connection mode and DirectQuery is unsupported. This fully addresses the wording-redundancy concern from the prior review pass — the conflicting "whenever possible" / "use DirectQuery if..." prose is gone, not layered on top.

Mintlify conventions: <Warning> block has the required blank lines inside the tags (powerbi.mdx:63-68); root-relative links unchanged; no docs.json update needed.

Link targets (powerbi.mdx:88-89): [link-powerbi-live] points to desktop-directquery-about#live-connections and [link-powerbi-directquery] to the same desktop-directquery-about page. Both resolve, but it is slightly odd that the "live connection" link goes to a page whose URL slug is directquery. Functionally fine; not blocking.

Nit — trailing newline (powerbi.mdx:90): file still ends without a trailing newline. Pre-existing from the prior commit, not introduced here.

docs-powerbi-live-connection-only

@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 40s —— View job


Code Review

Verdict: LGTM — 0 blocking, 1 nit. Docs-only change; no tests/security/perf concerns.

Review details
  • Read PR diff
  • Verified Mintlify conventions
  • Checked link targets
  • Posted review

Observations

Change is clean and accurate. The <Warning> callout at powerbi.mdx:63-71 clearly states the live-connection-only constraint and adds useful context that custom DAX queries are unsupported because they require DirectQuery. Wording is direct and reader-facing.

Mintlify conventions: <Warning> has the required blank lines inside the tags; link references are root-relative where appropriate; no docs.json update needed (existing page).

Nit — link target consistency (powerbi.mdx:91-92): [link-powerbi-live] points to desktop-directquery-about#live-connections — a section anchor within the DirectQuery page. Functionally correct (Microsoft documents live connection within the DirectQuery overview), but slightly odd that the "live connection" link's URL slug is directquery. Not worth changing unless Microsoft has a dedicated live-connection page.

• [`docs-powerbi-live-connection-only`](https://github.com/cube-js/cube/tree/docs-powerbi-live-connection-only)

@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 33s —— View job


Code Review

Verdict: LGTM — 0 blocking. Docs-only change; no tests/security/perf concerns.

Review details
  • Read PR diff
  • Verified Mintlify conventions
  • Checked link targets
  • Posted review

Observations

Change is clean and accurate. The <Warning> callout at powerbi.mdx:57-63 clearly states the live-connection-only constraint, calls out that both DirectQuery and Import mode are unsupported, and explains that custom DAX queries are unsupported because they require DirectQuery. Wording is direct and consistent across both copies of the page (admin/connect-to-data/visualization-tools/powerbi.mdx and docs/integrations/power-bi/index.mdx).

Mintlify conventions: <Warning> has the required blank lines inside the tags; link references are root-relative where appropriate; no docs.json update needed (existing pages).

Link target consistency: [link-powerbi-live] points to desktop-directquery-about#live-connections and [link-powerbi-directquery] to the same desktop-directquery-about page. Both resolve correctly — Microsoft documents live connection within the DirectQuery overview, so the shared base URL is appropriate.

No further changes needed.

• [`docs-powerbi-live-connection-only`](https://github.com/cube-js/cube/tree/docs-powerbi-live-connection-only)

Cube uses Power BI's live connection mode only; DirectQuery and import
mode are not supported. Because custom DAX queries require DirectQuery,
they are not supported either. Simplify the Power BI Connection methods
section and link to Microsoft's docs.

Also remove DirectQuery references from the DAX API docs (cross-view
filtering) for consistency, since DirectQuery is not supported.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@keydunov keydunov force-pushed the docs-powerbi-live-connection-only branch from 9991fe0 to 54ad14e Compare June 8, 2026 21:22
@claude

claude Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keydunov's task in 38s —— View job


Code Review

Verdict: LGTM — 0 blocking. Docs-only change; the DAX cross-view-filter and DAX index pages are now consistent with the live-connection-only framing on the Power BI pages.

Review details
  • Read PR diff (git diff HEAD~1 HEAD)
  • Verified Mintlify conventions
  • Checked link targets
  • Checked cross-file consistency

Observations

Consistency sweep is correct. The latest commit extends the live-connection-only message into the two DAX reference pages:

  • reference/core-data-apis/dax-api/cross-view-filter.mdx — drops the ## DirectQuery mode section and the intro line claiming support in both modes, renames ## Live connection mode to ## How it works. Consistent with the PowerBI pages now stating DirectQuery is unsupported.
  • reference/core-data-apis/dax-api/index.mdx — removes "in both Live connection and DirectQuery modes" from the cross-view-filter blurb.
  • admin/connect-to-data/visualization-tools/powerbi.mdx and docs/integrations/power-bi/index.mdx — identical <Warning> callout in both copies; tables removed; new [link-powerbi-live] and [link-powerbi-directquery] references added.

Mintlify conventions: <Warning> blocks have the required blank lines inside the tags in both copies. Reference-style link definitions are kept tidy.

Cross-file parity: The two Power BI pages remain identical, which is the existing convention for this duplicated content.

Nit — trailing newline (both Power BI files end without \n): pre-existing, not introduced here. Not worth a separate fix.

No further changes needed.

docs-powerbi-live-connection-only

@keydunov keydunov merged commit f7c2e1b into master Jun 8, 2026
9 checks passed
@keydunov keydunov deleted the docs-powerbi-live-connection-only branch June 8, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant